The advisory job was marked `continue-on-error`, which GitHub renders as a green check with an annotation — a signal nobody reads. Removed, so a failure shows as a real red X. What now keeps it from blocking merges is branch protection: it has to stay out of the required status checks. That is a repo setting rather than anything in this file, so it is called out in ci.yml and CLAUDE.md. Expect the job red occasionally through no fault of the change under test; that is the cost of it being visible. Also runs weekly (Mondays 06:00 UTC). A Rust release lands on its own schedule, so on push/PR alone breakage could sit unnoticed for weeks. The pinned `test` and `msrv` jobs skip scheduled runs — a pinned toolchain against a locked dependency graph cannot change on a timer. Adds a top-level `permissions: contents: read`, since the workflow needs nothing more. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
5.3 KiB
5.3 KiB
Changelog
All notable changes to this project will be documented in this file.
The format is based on Keep a Changelog, and this project adheres to Semantic Versioning.
[Unreleased]
Added
- A declared minimum supported Rust version of 1.88, verified by running
the test suite against it. The floor comes from the dependency graph
(
reqwest→url→idna→icu_*), not from this crate's own code. CI builds on both the MSRV and the pinned dev toolchain, plus a weekly advisory job on latest stable that reports breakage from a new Rust release. The advisory job fails visibly rather than silently; it is kept non-blocking through branch protection rather thancontinue-on-error. - Wrappers for every one of the API's 34
Route::resourcegroups, plususers— 265 methods. SeeCOVERAGE.mdfor the per-endpoint inventory. COVERAGE.md, a detailed record of what is wrapped, what is not, and why, checked againstroutes/api.phpon thev5-stablebranch.- Retry with full-jitter exponential backoff, configurable through
RetryPolicyandInvoiceNinjaClient::with_retry_policy. Defaults to 3 retries.Retry-Afteris honoured when the server sends it. InvoiceNinjaClient::with_timeoutand aDEFAULT_TIMEOUTof 60 seconds applied to every request.- Typed responses for previously untyped endpoints:
Statics,StaticItem,Currency,DateFormat,SearchResults,SearchHit,HealthCheck, andPhpVersion. statics_as,search_as, andhealth_check_asas generic escape hatches for callers who need to pin a shape the typed models leave inextra.tests/client_requests.rs: 50 tests covering the request plumbing against a loopbackwiremockserver. No network or credentials required.RetryPolicy::max_elapsed, a ceiling on the time one call may spend across all attempts, defaulting to 120 seconds. The request timeout is per attempt, so without this the default policy could spend four minutes on a call that times out repeatedly.
Changed
statics,search, andhealth_checkreturn concrete types instead of being generic overT: DeserializeOwned.send_emailnow unwraps thedataenvelope, soTis the entity (Invoice,Quote, …) rather than a wrapper the caller had to model. It stays generic because the endpoint serves all four entity types.chartremains generic, deliberately: the eleven chart endpoints share no common response shape, so there is nothing to narrow to.- The base URL is parsed and validated when the client is constructed. A missing scheme used to produce a 404 on every call instead of one error.
list_all_*terminates onmeta.pagination.total_pageswhen the server sends it, falling back to the short-page heuristic only when it does not.Erroris now#[non_exhaustive], so later variants are not a breaking change. Matches on it need a catch-all arm.Error::Jsonis now a struct variant carrying anexcerptof the body that failed to decode. The serde message alone ("expected value at line 1 column 1") does not reveal that the response was, say, an HTML error page from a proxy or a login redirect from a wrong base URL.- API errors with an empty or message-less body now report the status reason ("Not Found") instead of rendering blank.
Fixed
list_all_*silently truncated results. The server caps page size atmin(abs(per_page), 5000), so a page shorter than requested did not mean the last page — the walk stopped early and returned a partial list as though it were complete.per_pageis now clamped to the server maximum so the fallback heuristic holds.list_all_*withper_page(0)never terminated: the checkgot < 0has no solution. It now falls back to the default page size, and aMAX_PAGESbackstop raisesError::PaginationLimitrather than quietly truncating.- Requests could hang indefinitely.
reqwestapplies no timeout of its own and none was configured. - Ids were interpolated into request paths unescaped, so a
/,?, or#in an id changed which endpoint was addressed.
Security
- Ids used as URL path segments are escaped, and ids that are empty or
consist only of dots are rejected. Escaping alone is insufficient: the
WHATWG rules the
urlcrate implements decode%2Eback to.before resolving dot segments, so an escaped..still collapsed the path. An empty id would have addressed the collection route, makingdelete_client("")meanDELETE /clients. POSTis never replayed on a 5xx or timeout, since the server may have applied it before the response was lost and a replay would duplicate an invoice, payment, or email. A 429 is the exception — the server states it refused the request, so no work was done.- The API token and password are held as headers marked sensitive, so
neither appears in
Debugoutput.reqwest's ownClientdebug prints its default headers, so this is the only thing keeping the token out of logs; there is now a regression test pinning it.
[0.1.0] - 2026-10-23
Added
- Initial release: async client for the Invoice Ninja v5 API covering clients, invoices, quotes, credits, payments, products, expenses, projects, tasks, and vendors.