awkawb/invoiceninja-nixos
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nixos-module: remove nginx recommendedProxySettings, keep recommendedOptimisation

Browse Source 
recommendedProxySettings only adds proxy_* directives (proxy_redirect,
proxy_connect_timeout, proxy_set_header Connection, etc.), which only
take effect on locations using proxy_pass. This vhost only ever uses
fastcgi_pass for PHP, so the setting was inert here.

recommendedOptimisation (sendfile/tcp_nopush/tcp_nodelay/keepalive)
does apply regardless of proxy_pass vs fastcgi_pass, so it's kept.
Verified via the full automated test suite (both proxy backends).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
awkawb
2026-09-26 15:33:43 -04:00
co-authored by Claude Sonnet 5
parent 7d7d717745
commit fd055f0cf9
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nixos-module/invoiceninja.nix
-1
View File
@@ -486,7 +486,6 @@ in
recommendedTlsSettings = (if (cfg.hostname == "localhost") then false else true); recommendedTlsSettings = (if (cfg.hostname == "localhost") then false else true);
recommendedGzipSettings = true; recommendedGzipSettings = true;
recommendedProxySettings = true;
recommendedOptimisation = true; recommendedOptimisation = true;
clientMaxBodySize = cfg.maxUploadSize; clientMaxBodySize = cfg.maxUploadSize;