From fd055f0cf922f220b29230ae1d50937c98c12f06 Mon Sep 17 00:00:00 2001 From: Andrew Bryant Date: Sat, 26 Sep 2026 15:33:43 -0400 Subject: [PATCH] nixos-module: remove nginx recommendedProxySettings, keep recommendedOptimisation recommendedProxySettings only adds proxy_* directives (proxy_redirect, proxy_connect_timeout, proxy_set_header Connection, etc.), which only take effect on locations using proxy_pass. This vhost only ever uses fastcgi_pass for PHP, so the setting was inert here. recommendedOptimisation (sendfile/tcp_nopush/tcp_nodelay/keepalive) does apply regardless of proxy_pass vs fastcgi_pass, so it's kept. Verified via the full automated test suite (both proxy backends). Co-Authored-By: Claude Sonnet 5 --- nixos-module/invoiceninja.nix | 1 - 1 file changed, 1 deletion(-) diff --git a/nixos-module/invoiceninja.nix b/nixos-module/invoiceninja.nix index 83432cd..49ef42e 100644 --- a/nixos-module/invoiceninja.nix +++ b/nixos-module/invoiceninja.nix @@ -486,7 +486,6 @@ in recommendedTlsSettings = (if (cfg.hostname == "localhost") then false else true); recommendedGzipSettings = true; - recommendedProxySettings = true; recommendedOptimisation = true; clientMaxBodySize = cfg.maxUploadSize;