Pin the Rust toolchain and declare an MSRV of 1.88
The dev shell tracked `stable.latest` and CI used `@stable`, so nothing pinned a version and nothing declared a floor. A consumer on an older toolchain hit a confusing error deep in a dependency rather than cargo saying the version was too old, and a new stable release could turn a lint into an unrelated red build. - `rust-version = "1.88"` in Cargo.toml. The floor comes from the dependency graph, not this crate's code: reqwest pulls in url -> idna -> idna_adapter -> icu_*, and the icu crates require 1.88. Verified by running the full suite against 1.88, not inferred. - flake.nix pins the dev toolchain to 1.99.1 and adds an `msrv` devShell, so the floor can be rechecked with `nix develop .#msrv --command cargo test`. - CI pins the main job to the same 1.99.1 and adds a job building on 1.88. Lint and format stay on the pinned toolchain only, since their output varies by release. Note the tradeoff: with CI pinned, a future stable that breaks the build will not be noticed until the pin moves. Worth adding a non-blocking `stable` job if that matters. CLAUDE.md records the three places that must agree when either version moves, and how to recheck the floor after a dependency bump. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -14,6 +14,36 @@ This project uses Nix for toolchain management (Rust via `rust-overlay`):
|
||||
nix develop
|
||||
```
|
||||
|
||||
### Rust version
|
||||
|
||||
Two versions are pinned, and **three places must agree** when either moves:
|
||||
|
||||
| | Version | Declared in |
|
||||
| --- | --- | --- |
|
||||
| Dev toolchain | 1.99.1 | `devVersion` in `flake.nix`, `test` job in `ci.yml` |
|
||||
| MSRV | 1.88 | `msrvVersion` in `flake.nix`, `rust-version` in `Cargo.toml`, `msrv` job in `ci.yml` |
|
||||
|
||||
The MSRV is set by the **dependency graph**, not by this crate's code:
|
||||
`reqwest` pulls in `url` → `idna` → `idna_adapter` → `icu_*`, and the `icu`
|
||||
crates require 1.88. Recheck the floor after a dependency bump with:
|
||||
|
||||
```sh
|
||||
cargo metadata --format-version 1 \
|
||||
| jq -r '.packages[] | select(.rust_version) | "\(.rust_version)\t\(.name)"' \
|
||||
| sort -V | tail -5
|
||||
```
|
||||
|
||||
Verify a candidate MSRV actually builds before declaring it — the number
|
||||
above was confirmed by running the suite, not inferred:
|
||||
|
||||
```sh
|
||||
CARGO_TARGET_DIR=/tmp/msrv-target nix develop .#msrv --command cargo test
|
||||
```
|
||||
|
||||
Don't reach for a newer std API without checking it against the MSRV; a
|
||||
convenience like `Option::is_none_or` (1.82) is rarely worth raising the
|
||||
floor for.
|
||||
|
||||
## Common commands
|
||||
|
||||
```sh
|
||||
|
||||
Reference in New Issue
Block a user