Add entity action and PDF download to invoices/quotes/credits/purchase-orders
CI / test (push) Canceled after 0s
CI / Build on the declared MSRV (push) Canceled after 0s
CI / Latest stable (advisory) (push) Canceled after 0s

These four resources are the only ones with the SDK's
entity_action_methods! route. Adds:

- `action <id> <action>` - mark_sent, mark_paid, archive, restore,
  clone_to_invoice, clone_to_quote, auto_bill, delete (routed), returning
  the updated record.
- `download <id>...` - the rendered PDF, to stdout or `--out <path>`;
  more than one id streams a single merged PDF (Invoice Ninja's bulk
  download action).

New EntityResourceArgs/EntityAction in cli.rs rather than extending the
existing ResourceArgs/Action: Rust enums don't compose, and every
resource's `run` match on Action needs to stay exhaustive without a
catch-all arm for variants it doesn't support.

Found and fixed along the way: the Download variant's --output <path>
field collided by name with the global --output table|json flag,
causing clap to panic at runtime trying to downcast the wrong type.
Renamed to --out.

Extended tests/nixos-test.nix to exercise action/download for real
against the VM. That caught a test-ordering bug of its own - asserting
mark_sent on an invoice *after* paying it off, which correctly doesn't
revert status_id from paid back to sent - fixed by reordering the
subtests. nix flake check passes clean.

Also backfills two CHANGELOG.md gaps from earlier sessions: the VM test
and CI additions had never actually been logged there.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
2026-10-26 17:29:00 -04:00
co-authored by Claude Sonnet 5
parent c8a67b1208
commit 1236a15ebb
8 changed files with 262 additions and 36 deletions
+18 -1
View File
@@ -68,7 +68,7 @@ pkgs.testers.nixosTest {
assert updated["city"] == "Springfield", f"city not updated: {updated}"
assert updated["name"] == "CLI Test Client", f"update blanked a field it wasn't told about: {updated}"
with subtest("invoiceninja-cli can create an invoice against that client and see it in a payment"):
with subtest("invoiceninja-cli can create an invoice against that client"):
invoice_out = cli(
machine, token, "invoices", "create", "--data",
json.dumps({
@@ -79,6 +79,23 @@ pkgs.testers.nixosTest {
invoice = json.loads(invoice_out)[0]
assert invoice["amount"] == 100, f"unexpected invoice amount: {invoice}"
with subtest("invoiceninja-cli action marks the invoice sent, and download fetches a PDF"):
# Must run before the invoice is paid below: mark_sent on an
# already-paid invoice does not revert its status (status_id stays
# 4/paid, not 2/sent) - confirmed by this test failing that way
# the first time it was written in this order.
action_out = cli(machine, token, "invoices", "action", invoice["id"], "mark_sent")
acted = json.loads(action_out)[0]
assert acted["status_id"] == "2", f"mark_sent did not update status_id: {acted}"
machine.succeed(
f"IN_API_TOKEN={token} IN_BASE_URL=http://localhost/api/v1 "
f"invoiceninja-cli invoices download {invoice['id']} --out /tmp/invoice.pdf"
)
magic_bytes = machine.succeed("head -c 4 /tmp/invoice.pdf")
assert magic_bytes == "%PDF", f"expected a PDF, got: {magic_bytes!r}"
with subtest("invoiceninja-cli can pay the invoice in full"):
payment_out = cli(
machine, token, "payments", "create", "--data",
json.dumps({